Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quickfix cmd): construct items from visited buffers #68

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(quickfix cmd): construct items from visited buffers #68

merged 1 commit into from
Aug 31, 2023

Conversation

MariaSolOs
Copy link
Contributor

Fixes #64

akinsho
akinsho approved these changes Aug 31, 2023
View reviewed changes
Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@akinsho
Copy link
Owner

akinsho commented Aug 31, 2023

Thanks for all the contributions 🙌🏾

@akinsho akinsho merged commit cee519e into akinsho:main Aug 31, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Merged
@MariaSolOs
Copy link
Contributor Author

Thanks for all the contributions 🙌🏾

Thanks to YOU for the amazing plugins!

@MariaSolOs MariaSolOs deleted the paths branch August 31, 2023 15:07
@lvimuser
Copy link

This PR introduces a breaking change.

Before: we'd always call callback, even if #items == 0.
Now: callback may be called multiple times, but not when #items == 0.

Is that intended?

@MariaSolOs MariaSolOs mentioned this pull request Sep 17, 2023
Merged
@MariaSolOs
Copy link
Contributor Author

@lvimuser good catch! I opened #70 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinsho akinsho akinsho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: File paths in quickfix list are incorrect
3 participants
@MariaSolOs @akinsho @lvimuser